[ 
https://issues.apache.org/jira/browse/HDFS-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902653#comment-14902653
 ] 

Masatake Iwasaki commented on HDFS-9080:
----------------------------------------

* hdfs-default.xml: This should be {{fs.client.htrace.sampler.classes}}. This 
also should be moved to core-default.xml? FS_CLIENT_HTRACE_PREFIX is defined in 
CommonConfigurationKeys.java of hadoop-common.
{code}
-  <name>dfs.htrace.spanreceiver.classes</name>
+  <name>dfs.client.htrace.sampler.classes</name>
{code}


* TestHdfsConfigFields.java: We don't need this if the default configuration 
above is moved to core-default.xml.
{code}
-    // Ignore SpanReceiveHost properties
-    xmlPropsToSkipCompare.add("dfs.htrace.spanreceiver.classes");
-    xmlPropsToSkipCompare.add("dfs.client.htrace.spanreceiver.classes");
+    // Ignore HTrace properties
+    xmlPropsToSkipCompare.add("fs.client.htrace");
+    xmlPropsToSkipCompare.add("hadoop.htrace");
{code}


* {{dfs.htrace.spanreceiver.classes}} is sometimes found in Tracing.md. It 
should be fixed as {{hadoop.htrace.span.receiver.classes}}.


> update htrace version to 4.0
> ----------------------------
>
>                 Key: HDFS-9080
>                 URL: https://issues.apache.org/jira/browse/HDFS-9080
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.8.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-9080.001.patch, HDFS-9080.002.patch, 
> HDFS-9080.003.patch, HDFS-9080.004.patch, HDFS-9080.005.patch, 
> HDFS-9080.006.patch, HDFS-9080.007.patch, HDFS-9080.009.patch, 
> tracing-fsshell-put.png
>
>
> Update the HTrace library version Hadoop uses to htrace 4.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to