[
https://issues.apache.org/jira/browse/HDFS-9095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900971#comment-14900971
]
Bob Hansen commented on HDFS-9095:
----------------------------------
You may want to use CMAKE_CURRENT_LIST_DIR rather than CMAKE_CURRENT_SOURCE_DIR
as a more stable root directory.
I'm glad you started to add some logging and the start of an options
architecture. I was going to file another Jira for both of those (I probably
will to make a space for more full-featured efforts).
Following the experiences learned from the Java client, should the server
address be passed in with the options (eventually, they will probably all be
loaded from the same XML files at at startup).
In RpcConnection methods, should we be calling into the handler while holding
the lock on the engine state? If any method there does synchronous I/O or
hangs for any reason, the whole Rpc system locks up.
Can we have assertions that the lock is held in RpcConnection rather than
comments stating that it should be?
In RpcConnectionImpl, should options_ and next_layer_ be const?
> RPC client should fail gracefully when the connection is timed out or reset
> ---------------------------------------------------------------------------
>
> Key: HDFS-9095
> URL: https://issues.apache.org/jira/browse/HDFS-9095
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-9095.000.patch
>
>
> The RPC client should fail gracefully when the connection is timed out or
> reset. instead of bailing out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
