[
https://issues.apache.org/jira/browse/HDFS-9095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901053#comment-14901053
]
Haohui Mai commented on HDFS-9095:
----------------------------------
bq. You may want to use CMAKE_CURRENT_LIST_DIR rather than
CMAKE_CURRENT_SOURCE_DIR as a more stable root directory.
I don't understand why it's an issue here? I've not seen many people use
{{CMAKE_CURRENT_LIST_DIR}} in practice. ${CMAKE_CURRENT_SOURCE_DIR} will
points to {{hadoop-hdfs-project/hadoop-hdfs-client/src/main/native/libhdfspp}}.
When can it be a problem.
Following the experiences learned from the Java client, should the server
address be passed in with the options (eventually, they will probably all be
loaded from the same XML files at at startup).
bq. No. It's important to make the distinction here. Options specially mean
tunable parameters, while server addresses are input for the RPC library.
bq. In RpcConnection methods, should we be calling into the handler while
holding the lock on the engine state? If any method there does synchronous I/O
or hangs for any reason, the whole Rpc system locks up.
bq. Can we have assertions that the lock is held in RpcConnection rather than
comments stating that it should be?
This is a known issue coming from
https://github.com/haohui/libhdfspp/issues/39. Please feel free to file jiras
to fix it.
In RpcConnectionImpl, should options_ and next_layer_ be const?
bq. {{next_layer_}} cannot be const, but options_ should be. Will fix it.
> RPC client should fail gracefully when the connection is timed out or reset
> ---------------------------------------------------------------------------
>
> Key: HDFS-9095
> URL: https://issues.apache.org/jira/browse/HDFS-9095
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-9095.000.patch
>
>
> The RPC client should fail gracefully when the connection is timed out or
> reset. instead of bailing out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
