[
https://issues.apache.org/jira/browse/HDFS-9095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901293#comment-14901293
]
James Clampffer commented on HDFS-9095:
---------------------------------------
Agree with bob about making the CMakeLists as robust as possible, otherwise +1
on the patch. Getting in the basics for logging is very nice as well.
Re: In RpcConnection methods, should we be calling into the handler while
holding the lock on the engine state? If any method there does synchronous I/O
or hangs for any reason, the whole Rpc system locks up.
This was done to avoid using a std::recursive_mutex because right now that
handler only gets called from OnRecvCompleted. I don't think the handler is
going to be changing much unless we start using multiple connections from a
single RpcEngine. Lock contention is one of the things I hope to start
profiling soon; if the overhead is negligible I'll switch that back to a
recursive_mutex and grab the lock in the handler as well (I'll file a jira if
that's the case).
> RPC client should fail gracefully when the connection is timed out or reset
> ---------------------------------------------------------------------------
>
> Key: HDFS-9095
> URL: https://issues.apache.org/jira/browse/HDFS-9095
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-9095.000.patch
>
>
> The RPC client should fail gracefully when the connection is timed out or
> reset. instead of bailing out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
