[
https://issues.apache.org/jira/browse/HDFS-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035142#comment-15035142
]
Tony Wu commented on HDFS-9491:
-------------------------------
Manually ran the failed tests: TestWriteReadStripedFile,
TestRenameWithSnapshots & TestDFSStripedOutputStreamWithFailure130 with JDK 1.8
and 1.7 on OSX. All tests pass without error. None of the failed tests use
{{getPendingAsyncDeletions}} so it should not be related to the patch.
ASF License warning is also not related to the patch as it does not include any
license related change.
> Tests should get the number of pending async delets via FsDatasetTestUtils
> --------------------------------------------------------------------------
>
> Key: HDFS-9491
> URL: https://issues.apache.org/jira/browse/HDFS-9491
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Affects Versions: 2.7.1
> Reporter: Tony Wu
> Assignee: Tony Wu
> Priority: Minor
> Attachments: HDFS-9491.001.patch
>
>
> A few unit tests use {{DataNodeTestUtils#getPendingAsyncDeletions}} to
> retrieve the number of pending async deletions. It internally calls
> {{FsDatasetTestUtil#getPendingAsyncDeletions}}:
> {code:java}
> public static long getPendingAsyncDeletions(FsDatasetSpi<?> fsd) {
> return ((FsDatasetImpl)fsd).asyncDiskService.countPendingDeletions();
> }
> {code}
> This assumes {{FsDatasetImpl}} is (the only implementation of) {{FsDataset}}.
> However {{FsDataset}} is pluggable and can have other implementations.
> We can abstract getting the number of async deletions in
> {{FsDatasetTestUtils}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
