[ 
https://issues.apache.org/jira/browse/HDFS-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042017#comment-15042017
 ] 

Tony Wu commented on HDFS-9491:
-------------------------------

Hi [~eddyxu],

I Just rebased the patch on latest trunk and ran a few tests. It was able to 
build correctly and the selected tests also ran without issue. Please take a 
look at the v2 patch.

Thanks,
Tony

> Tests should get the number of pending async delets via FsDatasetTestUtils
> --------------------------------------------------------------------------
>
>                 Key: HDFS-9491
>                 URL: https://issues.apache.org/jira/browse/HDFS-9491
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.7.1
>            Reporter: Tony Wu
>            Assignee: Tony Wu
>            Priority: Minor
>         Attachments: HDFS-9491.001.patch, HDFS-9491.002.patch
>
>
> A few unit tests use {{DataNodeTestUtils#getPendingAsyncDeletions}} to 
> retrieve the number of pending async deletions. It internally calls 
> {{FsDatasetTestUtil#getPendingAsyncDeletions}}:
> {code:java}
> public static long getPendingAsyncDeletions(FsDatasetSpi<?> fsd) {
>     return ((FsDatasetImpl)fsd).asyncDiskService.countPendingDeletions();
> }
> {code}
> This assumes {{FsDatasetImpl}} is (the only implementation of) {{FsDataset}}. 
> However {{FsDataset}} is pluggable and can have other implementations.
> We can abstract getting the number of async deletions in 
> {{FsDatasetTestUtils}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to