[
https://issues.apache.org/jira/browse/HDFS-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041951#comment-15041951
]
Lei (Eddy) Xu commented on HDFS-9491:
-------------------------------------
Hi, [~twu]
This patch can not compile on trunk
{code}
[ERROR] location: interface
org.apache.hadoop.hdfs.server.datanode.FsDatasetTestUtils
[ERROR]
/Users/lei/work/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java:[381,3]
method does not override or implement a method from a supertype
[ERROR]
/Users/lei/work/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/HATestUtil.java:[104,48]
cannot find symbol
{code}
Could you fix it and re-submit your patch? Thanks
> Tests should get the number of pending async delets via FsDatasetTestUtils
> --------------------------------------------------------------------------
>
> Key: HDFS-9491
> URL: https://issues.apache.org/jira/browse/HDFS-9491
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Affects Versions: 2.7.1
> Reporter: Tony Wu
> Assignee: Tony Wu
> Priority: Minor
> Attachments: HDFS-9491.001.patch
>
>
> A few unit tests use {{DataNodeTestUtils#getPendingAsyncDeletions}} to
> retrieve the number of pending async deletions. It internally calls
> {{FsDatasetTestUtil#getPendingAsyncDeletions}}:
> {code:java}
> public static long getPendingAsyncDeletions(FsDatasetSpi<?> fsd) {
> return ((FsDatasetImpl)fsd).asyncDiskService.countPendingDeletions();
> }
> {code}
> This assumes {{FsDatasetImpl}} is (the only implementation of) {{FsDataset}}.
> However {{FsDataset}} is pluggable and can have other implementations.
> We can abstract getting the number of async deletions in
> {{FsDatasetTestUtils}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
