[
https://issues.apache.org/jira/browse/HDFS-9430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035342#comment-15035342
]
Vinayakumar B commented on HDFS-9430:
-------------------------------------
bq. In addition, should we remove the tracking of FSNamesystem#imageLoaded
altogether?
I think tracking is used to decide to whether quota check is required or not.
Quota check not required during editlog processing, during which
{{FSNamesystem#imageLoaded}} will be false.
So, IMO, removing of this tracker not required.
bq. Haohui Mai could clarify the intention of checking imageLoaded during RPC
processing
IMO, waitForLoadingFsImage() was trying to ensure full loading of image before
serving RPC requests. This was a movement one level higher from FSDirectory to
FSNameSystem in HDFS-6480 and included RPC requests as well. At the time this
check was added, checkNNStartup() was not present. {{checkNNStartup()}} was
added to ensure full services startup,(mainly transition RPCs which doesnt come
under waitForLoadingFsImage() check), along with fsImage load in HDFS-3443
which committed in Jan-2015.
I think its fair to remove {{waitForLoadingFsImage()}} but leave the tracker
{{FSNamesystem#imageLoaded}} and get/setter for it as is.
> waitforloadingfsimage() can be removed since checknnstartup() already ensures
> image loaded and namenode started.
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-9430
> URL: https://issues.apache.org/jira/browse/HDFS-9430
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HDFS-9430.patch
>
>
> After initial startup,loading fsimage in between happens only for
> secondarynn..But it wn't server any client requests.
> So IMO it would be ok to remove it.
> Please check commement [here
> |https://issues.apache.org/jira/browse/HDFS-9413?focusedCommentId=15005129&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15005129]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
