[
https://issues.apache.org/jira/browse/HDFS-9430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036414#comment-15036414
]
Haohui Mai commented on HDFS-9430:
----------------------------------
It's okay to remove the {{waitForLoadingFsImage()}} function but I think it
requires more refactoring to get things right.
bq. I think its fair to remove waitForLoadingFsImage() but leave the tracker
FSNamesystem#imageLoaded and get/setter for it as is.
Today the paradigm is broken. We assume that when replaying editlogs that the
NN ops will call functions (i.e., {{unprotected*}})that bypass all checks
including quotas, etc. This is clearly broken for all callers of
{{fsn.isImageLoaded()}} and {{fsd.shouldSkipQuotaChecks()}}. I think it's okay
to file a follow-up jira to address this.
> waitforloadingfsimage() can be removed since checknnstartup() already ensures
> image loaded and namenode started.
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-9430
> URL: https://issues.apache.org/jira/browse/HDFS-9430
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HDFS-9430.patch
>
>
> After initial startup,loading fsimage in between happens only for
> secondarynn..But it wn't server any client requests.
> So IMO it would be ok to remove it.
> Please check commement [here
> |https://issues.apache.org/jira/browse/HDFS-9413?focusedCommentId=15005129&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15005129]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
