[ 
https://issues.apache.org/jira/browse/HDFS-9430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036391#comment-15036391
 ] 

Ming Ma commented on HDFS-9430:
-------------------------------

Thanks [~vinayrpet] for the explanation. Make sense to keep the 
{{FSNamesystem#imageLoaded}} get/setter around for quota check during edit log 
replay at NN startup.

My main question was around the order of fsimage loading and RPC server 
startup. In {NameNode}}'s {{initialize}} function, {{loadNamesystem}} sets 
{{imageLoaded}} to true and it is called before RPC server is started. Thus 
when RPC methods are processed, {{imageLoaded}} should have been set to true.

{noformat}
    loadNamesystem(conf);
    rpcServer = createRpcServer(conf);
{noformat}

I will wait until the end of the week for [~szetszwo] and [~wheat9] to provide 
any additional comments they might have before commit.

> waitforloadingfsimage() can be removed since checknnstartup() already ensures 
> image loaded and namenode started.
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-9430
>                 URL: https://issues.apache.org/jira/browse/HDFS-9430
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HDFS-9430.patch
>
>
> After initial startup,loading fsimage in between happens only for 
> secondarynn..But it wn't server any client requests.
> So IMO it would be ok to remove it.
> Please check commement [here 
> |https://issues.apache.org/jira/browse/HDFS-9413?focusedCommentId=15005129&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15005129]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to