[
https://issues.apache.org/jira/browse/HDFS-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038103#comment-15038103
]
Bob Hansen commented on HDFS-9448:
----------------------------------
[~aw] - thanks for your patience.
As it stands, the patch works both with and without valgrind (tested against
the docker file so helpfully provided, and is basically a no-op without
valgrind). I think we're in violent agreement that we should have valgrind
added to the hadoop docker image, and it should be used by these tests when
available.
My questions are a matter of Apache + Hadoop process and culture, and may just
reveal how much I have to learn here. I think my open questions are:
* To add valgrind to the Hadoop docker image, where should I file a Jira and a
patch? Is it an HDFS bug (since the forcing function is drawn from this HDFS
patch), or a Hadoop Common bug, or an Apache Yetus bug (which I think is the
running environment, correct)?
* Should I submit this patch (which brings value when valgrind is present, as
in most dev machines) that won't add value to the CI process or should I wait
until the docker image has valgrind
> Enable valgrind for libhdfspp unit tests
> ----------------------------------------
>
> Key: HDFS-9448
> URL: https://issues.apache.org/jira/browse/HDFS-9448
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Bob Hansen
> Assignee: Bob Hansen
> Attachments: HDFS-9448.HDFS-8707.000.patch,
> HDFS-9448.HDFS-8707.001.patch, HDFS-9448.HDFS-8707.002.patch
>
>
> We should have a target that runs the unit tests under valgrind if it is
> available on the target machine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
