[
https://issues.apache.org/jira/browse/HDFS-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042279#comment-15042279
]
Allen Wittenauer commented on HDFS-9448:
----------------------------------------
So yeah, looking closer at this, I think we should probably change things just
a hair to be more consistent:
a) by default, it should definitely compile and run all the (applicable) unit
test if valgrind isn't around.
b) if -Drequire.valgrind is set to true, then the build should *fail* if
valgrind isn't present. This allows for REs to make sure the build environment
is in a correct and expected state.
bq. To add valgrind to the Hadoop docker image, where should I file a Jira and
a patch? Is it an HDFS bug (since the forcing function is drawn from this HDFS
patch), or a Hadoop Common bug, or an Apache Yetus bug (which I think is the
running environment, correct)?
The dockerfile is literally hadoop/dev-support/docker/Dockerfile . Yetus is
pretty irrelevant here: it's using the dockerfile that hadoop provides.
bq. Should I submit this patch (which brings value when valgrind is present, as
in most dev machines) that won't add value to the CI process or should I wait
until the docker image has valgrind
This patch needs to add valgrind to the dockerfile since this patch is the one
that is introducing the dependency. I'm pretty much -1 on any other outcome
but that one.
> Enable valgrind for libhdfspp unit tests
> ----------------------------------------
>
> Key: HDFS-9448
> URL: https://issues.apache.org/jira/browse/HDFS-9448
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Bob Hansen
> Assignee: Bob Hansen
> Attachments: HDFS-9448.HDFS-8707.000.patch,
> HDFS-9448.HDFS-8707.001.patch, HDFS-9448.HDFS-8707.002.patch
>
>
> We should have a target that runs the unit tests under valgrind if it is
> available on the target machine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
