[ 
https://issues.apache.org/jira/browse/HDFS-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163843#comment-15163843
 ] 

Colin Patrick McCabe commented on HDFS-9853:
--------------------------------------------

Thanks, Anu.

{code}
96        // A string that identifies this command, we generate  Trace ID in 
Ozone
97        // frontend and this allows us to trace that command all over ozone.
98        optional string traceID = 2;
{code}
HTrace trace IDs are 128-bit integers.  I think we should avoid using a string 
here since it is not as efficient as simply using two 64-bit numbers.  I also 
don't see why the response needs a trace ID, since the client knows the ID of 
the request it sent.

> Ozone: Add container definitions
> --------------------------------
>
>                 Key: HDFS-9853
>                 URL: https://issues.apache.org/jira/browse/HDFS-9853
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: HDFS-9853-HDFS-7240.001.patch, 
> HDFS-9853-HDFS-7240.002.patch
>
>
> This patch introduces protoc definitions that operate against the container 
> on a datanode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to