[
https://issues.apache.org/jira/browse/HDFS-9817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181445#comment-15181445
]
Mingliang Liu commented on HDFS-9817:
-------------------------------------
Hi [~anu], I see you changed log level at several places. Is this on purpose?
Generally I'm in favor of the change. Thanks.
Nit:
{code:title=ConnectorFactory.java#getCluster()}
41 LOG.debug("Cluster URI : {}" , clusterURI);
42 LOG.debug("scheme : {}" , clusterURI.getScheme());
{code}
You can merge them in one line, along with some meaningful message.
> Use SLF4J in new classes
> ------------------------
>
> Key: HDFS-9817
> URL: https://issues.apache.org/jira/browse/HDFS-9817
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: logging
> Affects Versions: HDFS-1312
> Reporter: Arpit Agarwal
> Assignee: Anu Engineer
> Attachments: HDFS-9817-HDFS-1312.001.patch,
> HDFS-9817-HDFS-1312.002.patch
>
>
> We are trying to use SLF4J for new classes as far as possible so let's change
> all the newly added classes to use SLF4J instead of depending on Log4J.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
