[
https://issues.apache.org/jira/browse/HDFS-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194786#comment-15194786
]
Uma Maheswara Rao G commented on HDFS-9694:
-------------------------------------------
[~drankye], Thanks for working on this patch. Great work.
Here is my comments/questions
# StripedBlockChecksumComputer : Seems like we will actually don’t do anything
with stripes here. We are calculating checksum by block levels right. So, this
should be like StripedBGBlockCheksumComputer/BlockGroupBlockChecksumComputer ?
So that later When we implement pure stripe based checksum calculation we could
name it as StripedBGStripeCheksumComputer/BlockGroupStripedChecksumComputer?
Just a thought.
# StripedFileChecksumComputer : Here also same as above. But I am not strong on
name at this time but below is my thought, How about
StripedFileBlkLevelChecksumComputer and Later when we compute stripe based
computer we name it as StripedFileStripeLevelChecksumComputer? Just a thought,
it will great if we get more better meaningful naming.
# I think client’s getFileCheckSum should have proper java doc which would
explain that when we call this API on striped file, it should say that block
level checksum would be calculated but not stripe level and checksum result
can’t be compared with replicated file checksum result.
> Make existing DFSClient#getFileChecksum() work for striped blocks
> -----------------------------------------------------------------
>
> Key: HDFS-9694
> URL: https://issues.apache.org/jira/browse/HDFS-9694
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HDFS-9694-v1.patch, HDFS-9694-v2.patch,
> HDFS-9694-v3.patch, HDFS-9694-v4.patch, HDFS-9694-v5.patch
>
>
> This is a sub-task of HDFS-8430 and will get the existing API
> {{FileSystem#getFileChecksum(path)}} work for striped files. It will also
> refactor existing codes and layout basic work for subsequent tasks like
> support of the new API proposed there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
