[ 
https://issues.apache.org/jira/browse/HDFS-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207137#comment-15207137
 ] 

Uma Maheswara Rao G commented on HDFS-9694:
-------------------------------------------



Hi [~drankye], I have a question, 
{code}
 send(out, Op.BLOCK_GROUP_CHECKSUM, proto);
{code}
Are you planning to have a flag to indicate striped or non striped modes later? 
or you want to have separate flag itself?

NonStripedBlockGroupChecksumComputer --> BlockGroupNonStripedChecksumComputer 
is more consistent with StripedFileNonStripedChecksumComputer?

Other than this mostly looks good to me. Once they addressed and if no 
objections from others, I plan to commit this. 

> Make existing DFSClient#getFileChecksum() work for striped blocks
> -----------------------------------------------------------------
>
>                 Key: HDFS-9694
>                 URL: https://issues.apache.org/jira/browse/HDFS-9694
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HDFS-9694-v1.patch, HDFS-9694-v2.patch, 
> HDFS-9694-v3.patch, HDFS-9694-v4.patch, HDFS-9694-v5.patch, 
> HDFS-9694-v6.patch, HDFS-9694-v7.patch
>
>
> This is a sub-task of HDFS-8430 and will get the existing API 
> {{FileSystem#getFileChecksum(path)}} work for striped files. It will also 
> refactor existing codes and layout basic work for subsequent tasks like 
> support of the new API proposed there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to