[ https://issues.apache.org/jira/browse/HDFS-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229078#comment-15229078 ]
Wei-Chiu Chuang commented on HDFS-10267: ---------------------------------------- One nitt: Instead of {code} LOG.debug("initiating recoverClose"); {code} You might change that to {code} LOG.debug("initiating " + op); {code} > Extra "synchronized" on FsDatasetImpl#recoverAppend and > FsDatasetImpl#recoverClose > ---------------------------------------------------------------------------------- > > Key: HDFS-10267 > URL: https://issues.apache.org/jira/browse/HDFS-10267 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Affects Versions: 2.8.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-10267.001.patch, HDFS-10267.002.patch > > > There is an extra "synchronized" on FsDatasetImpl#recoverAppend and > FsDatasetImpl#recoverClose that prevents the HDFS-8496 fix from working as > intended. This should be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)