[
https://issues.apache.org/jira/browse/HDFS-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229088#comment-15229088
]
Wei-Chiu Chuang commented on HDFS-10267:
----------------------------------------
Thanks for the fix!
Since the test catches {{InterruptedException}}, the timeout
{code}
@Test(timeout=60000)
public void testRecoverAppendDoesNotHoldLock() throws Exception {
{code}
for the test will not work. It would be great if this can be addressed,
otherwise the rest looks good to me!
> Extra "synchronized" on FsDatasetImpl#recoverAppend and
> FsDatasetImpl#recoverClose
> ----------------------------------------------------------------------------------
>
> Key: HDFS-10267
> URL: https://issues.apache.org/jira/browse/HDFS-10267
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.8.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-10267.001.patch, HDFS-10267.002.patch
>
>
> There is an extra "synchronized" on FsDatasetImpl#recoverAppend and
> FsDatasetImpl#recoverClose that prevents the HDFS-8496 fix from working as
> intended. This should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
