[
https://issues.apache.org/jira/browse/HDFS-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229404#comment-15229404
]
Xiao Chen commented on HDFS-10267:
----------------------------------
Thanks [~cmccabe] for working on this, patch looks great! Also thanks all for
reviewing.
Some nitty comments on Patch 3:
- javadoc of {{uninterruptiblyAcquire}} has redundant parameter: {code} *
@param sem The semaphore.{code}
- we could use {{GenericTestUtils#assertExceptionContains}} to check exception
message
- javadoc on {{testStopWorker}} should be updated (replace initReplicaRecovery)
{code}
* Test that initReplicaRecovery does ...
{code}
Checkstyle is probably gonna catch these:
- extra line on line 858-859, before {{TestStopWorkerRunnable}}
- extra space in the end of line 1000:
{code}LOG.error("stopWriterThread got unexpected exception for " + {code}
+1 (non-binding) once the above addressed.
> Extra "synchronized" on FsDatasetImpl#recoverAppend and
> FsDatasetImpl#recoverClose
> ----------------------------------------------------------------------------------
>
> Key: HDFS-10267
> URL: https://issues.apache.org/jira/browse/HDFS-10267
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.8.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-10267.001.patch, HDFS-10267.002.patch,
> HDFS-10267.003.patch
>
>
> There is an extra "synchronized" on FsDatasetImpl#recoverAppend and
> FsDatasetImpl#recoverClose that prevents the HDFS-8496 fix from working as
> intended. This should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
