[ 
https://issues.apache.org/jira/browse/HDFS-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388504#comment-15388504
 ] 

Inigo Goiri commented on HDFS-10629:
------------------------------------

[~jakace], thanks for the patch, I think 001 is a pretty good skeleton for the 
{{Router}}.
A couple things to fix:
* Checkstyles, licenses, javadoc, etc.
* I think the findbugs are solvable.
* Add unit tests for the basic Router service functionality.
* The connections from Router to Namenode in the {{ConnectionManager}} is a 
little primitive but I think is good for now; we may want to add a TODO for 
that and extend the comments explaining the approach.
* Not sure we need the {{RouterSafemodeService}}; we may need this in the 
future for rebalancing but let's keep it out for now.
* Add a comment to the {{StateStore}} saying that it will be added under 
HDFS-10630.

> Federation Router
> -----------------
>
>                 Key: HDFS-10629
>                 URL: https://issues.apache.org/jira/browse/HDFS-10629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs
>            Reporter: Inigo Goiri
>            Assignee: Jason Kace
>         Attachments: HDFS-10629.000.patch, HDFS-10629.001.patch
>
>
> Component that routes calls from the clients to the right Namespace. It 
> implements {{ClientProtocol}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to