[
https://issues.apache.org/jira/browse/HDFS-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388987#comment-15388987
]
Rakesh R commented on HDFS-10629:
---------------------------------
Good work, thanks [~jakace] for the patch. It gives an overall idea about the
{{Router}} service, which provides a unified view of multiple federated HDFS
clusters.
Adding few quick suggestions and I'll post a full review shortly. It looks like
the patch is quite big and imho, it would be good to split into
multiple/smaller logical chunks and push it separately. That would help
reviewers to focus on specific set of cases and also get chance for better test
coverage. I could see there is a branch created for this feature. Perhaps we
could encourage to create patch from that. While uploading/attaching the patch
to jira, it should be named with the feature branch name so that {{Jenkins}}
will automatically pick up this patch and run against the branch code. For
example, {{HDFS-10629-HDFS-10467-00.patch}}
> Federation Router
> -----------------
>
> Key: HDFS-10629
> URL: https://issues.apache.org/jira/browse/HDFS-10629
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Inigo Goiri
> Assignee: Jason Kace
> Attachments: HDFS-10629.000.patch, HDFS-10629.001.patch
>
>
> Component that routes calls from the clients to the right Namespace. It
> implements {{ClientProtocol}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
