[ 
https://issues.apache.org/jira/browse/HDFS-10996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15653005#comment-15653005
 ] 

SammiChen commented on HDFS-10996:
----------------------------------

Hi Rakesh, thank you very much for helping review the patch and give so 
valuable comments!

All items will be taken care in next patch. For the last question, my original 
thought is to improving the {{setErasureCodingPolicy}} and not change the 
{{create}} function. But after I did some investigation, I found this way 
doesn't work. Because a {{FSDataOutputStream}} will be returned by {{create}} 
function, then this {{FSDataOutputStream}} will be used immediately to flush 
data out. So in order to apply the erasure coding policy to the new file at the 
very beginning, {{erasureCodingPolicy}} must be passed to create function as a 
parameter. So far {{setErausreCodingPolicy}} only applies to directory, not 
file. Set a erasure coding policy to an existing file, will trigger the file 
content transformed from one redundancy policy to another. I have created a new 
JIRA HDFS-11075 to track it. 

Several checkstyle issues are about "More than 7 parameters" of some existing 
functions, for example, {{ClientProtocol#create}}. I'm prone to keep the 
current behaviour. 



> Ability to specify per-file EC policy at create time
> ----------------------------------------------------
>
>                 Key: HDFS-10996
>                 URL: https://issues.apache.org/jira/browse/HDFS-10996
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Andrew Wang
>            Assignee: SammiChen
>         Attachments: HDFS-10996-v1.patch
>
>
> Based on discussion in HDFS-10971, it would be useful to specify the EC 
> policy when the file is created. This is useful for situations where app 
> requirements do not map nicely to the current directory-level policies.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to