[
https://issues.apache.org/jira/browse/HDFS-10881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941238#comment-15941238
]
Subru Krishnan commented on HDFS-10881:
---------------------------------------
Thanks [~jakace] and [~elgoiri] for working on this. I looked at the latest
patch and have a few questions/comments:
* {{FederationStateStoreService}} initializes a {{StateStoreDriver}} which in
turn has a reference to the {{FederationStateStoreService}} itself. Can we
decouple the two? I am fine with the former but not getting/missing why we need
the latter.
* {{StateStoreDriver}} is an abstract class. Can we have a simple
*StateStore* interface and then have an abstract driver which the actual
implementations can implement. The reason for the request is that we can
restrict client interactions to the interface.
* IIUC, implementing classes have the full flexibility for optimizations like
predicate pushdowns, etc? If so, can you clearly call that out. If not, we need
to allow for that.
* Can we have a trivial (brute force) filter implementation in
{{FederationStateStoreUtils}} as I am concerned with simply returning null.
* Why do you have the version for each {{BaseRecord}}? I think we should look
at versioning at *record class* level.
* Test cases are missing for the driver & utils.
* Nit on class naming: There doesn't seem to be a consistency as few classes
have _Federation_ prefix while others do not. Also there are clashes with
classes used in Yarn Federation (YARN-2915).
> Federation State Store Driver API
> ---------------------------------
>
> Key: HDFS-10881
> URL: https://issues.apache.org/jira/browse/HDFS-10881
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: fs
> Reporter: Jason Kace
> Assignee: Jason Kace
> Attachments: HDFS-10881-HDFS-10467-001.patch,
> HDFS-10881-HDFS-10467-002.patch, HDFS-10881-HDFS-10467-003.patch,
> HDFS-10881-HDFS-10467-004.patch, HDFS-10881-HDFS-10467-005.patch,
> HDFS-10881-HDFS-10467-006.patch, HDFS-10881-HDFS-10467-007.patch,
> HDFS-10881-HDFS-10467-008.patch, HDFS-10881-HDFS-10467-009.patch
>
>
> The API interfaces and minimal classes required to support a state store data
> backend such as ZooKeeper or a file system.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
