[
https://issues.apache.org/jira/browse/HDFS-10881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948108#comment-15948108
]
Subru Krishnan commented on HDFS-10881:
---------------------------------------
Thanks [~elgoiri] for addressing my comments. The latest patch (v13) LGTM.
Couple of minor nits:
* Can we rename *version* attribute in {{QueryResult}} to *timestamp* as
that's what the field contains since we agreed to have the version at record
class level.
* For the same reason, I think we don't need
{{BaseRecord::getUniqueIdentifier}} any longer.
* Looks like some of the Javadocs still retain the _Federation_ prefix.
> Federation State Store Driver API
> ---------------------------------
>
> Key: HDFS-10881
> URL: https://issues.apache.org/jira/browse/HDFS-10881
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: fs
> Reporter: Jason Kace
> Assignee: Jason Kace
> Attachments: HDFS-10881-HDFS-10467-001.patch,
> HDFS-10881-HDFS-10467-002.patch, HDFS-10881-HDFS-10467-003.patch,
> HDFS-10881-HDFS-10467-004.patch, HDFS-10881-HDFS-10467-005.patch,
> HDFS-10881-HDFS-10467-006.patch, HDFS-10881-HDFS-10467-007.patch,
> HDFS-10881-HDFS-10467-008.patch, HDFS-10881-HDFS-10467-009.patch,
> HDFS-10881-HDFS-10467-010.patch, HDFS-10881-HDFS-10467-011.patch,
> HDFS-10881-HDFS-10467-012.patch, HDFS-10881-HDFS-10467-013.patch
>
>
> The API interfaces and minimal classes required to support a state store data
> backend such as ZooKeeper or a file system.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
