[
https://issues.apache.org/jira/browse/HDFS-10881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946100#comment-15946100
]
Chris Douglas commented on HDFS-10881:
--------------------------------------
Mostly minor things. I suspect many of the points I'm confused on would be
clearer in context
* naming; Since {{updateOrCreate}} sets a policy for existing values, would
{{put}} be clearer?
* Can the fields on {{QueryResult}} be final?
* What is the intent behind {{BaseRecord#initDefaultTimes}}? Would a sentinel
value (e.g., \-1) serve the same purpose?
* {{BaseRecord#isPrimaryKeyFolder}} it's not clear what this means
* The semantics of {{delete}} (rename to {{remove}}?) are unclear. If the item
doesn't exist, does this succeed? If some records in the filter are removed, or
if no records match, is the operation successful?
* Why does {{getPrimaryKeys}} need to be a {{SortedMap}}? Is that important to
its semantics?
> Federation State Store Driver API
> ---------------------------------
>
> Key: HDFS-10881
> URL: https://issues.apache.org/jira/browse/HDFS-10881
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: fs
> Reporter: Jason Kace
> Assignee: Jason Kace
> Attachments: HDFS-10881-HDFS-10467-001.patch,
> HDFS-10881-HDFS-10467-002.patch, HDFS-10881-HDFS-10467-003.patch,
> HDFS-10881-HDFS-10467-004.patch, HDFS-10881-HDFS-10467-005.patch,
> HDFS-10881-HDFS-10467-006.patch, HDFS-10881-HDFS-10467-007.patch,
> HDFS-10881-HDFS-10467-008.patch, HDFS-10881-HDFS-10467-009.patch,
> HDFS-10881-HDFS-10467-010.patch, HDFS-10881-HDFS-10467-011.patch
>
>
> The API interfaces and minimal classes required to support a state store data
> backend such as ZooKeeper or a file system.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
