[ 
https://issues.apache.org/jira/browse/HDFS-10630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965369#comment-15965369
 ] 

Chris Douglas commented on HDFS-10630:
--------------------------------------

* Are the File impls primarily for testing? Or do routers communicate through 
the FS?
* Should {{StateStoreConnectionMonitorService#serviceInit}} call 
{{super.serviceInit(conf)}}?
* {{PeriodicService}} probably shouldn't accept calls to its set\* methods 
after it's started
* start/stop of {{PeriodicService}} should probably be synchronized
* Why is the {{StateStoreService}} a singleton? It doesn't seem to follow, or 
benefit, from the {{Service}} pattern.
* The {{StateStoreUtils}} serialization methods using reflection are very 
general...

> Federation State Store FS Implementation
> ----------------------------------------
>
>                 Key: HDFS-10630
>                 URL: https://issues.apache.org/jira/browse/HDFS-10630
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs
>            Reporter: Inigo Goiri
>            Assignee: Jason Kace
>         Attachments: HDFS-10630.001.patch, HDFS-10630.002.patch, 
> HDFS-10630-HDFS-10467-003.patch, HDFS-10630-HDFS-10467-004.patch, 
> HDFS-10630-HDFS-10467-005.patch
>
>
> Interface to store the federation shared state across Routers.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to