[
https://issues.apache.org/jira/browse/HDFS-10630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993893#comment-15993893
]
Chris Douglas commented on HDFS-10630:
--------------------------------------
+1 lgtm
Minor, not blocking commit
* param javadoc for {{PeriodicService}} doesn't specify the time unit (ms)
* The TimeUnit conversions from constants to millis don't seem necessary
* {{+ conf.set(DFSConfigKeys.DFS_PERMISSIONS_ENABLED_KEY, "true");}} use
conf.setBoolean
* {{+ conf.set(FEDERATION_STORE_DRIVER_CLASS, clazz.getCanonicalName());}}
use conf.setClass
> Federation State Store FS Implementation
> ----------------------------------------
>
> Key: HDFS-10630
> URL: https://issues.apache.org/jira/browse/HDFS-10630
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Inigo Goiri
> Assignee: Jason Kace
> Attachments: HDFS-10630.001.patch, HDFS-10630.002.patch,
> HDFS-10630-HDFS-10467-003.patch, HDFS-10630-HDFS-10467-004.patch,
> HDFS-10630-HDFS-10467-005.patch, HDFS-10630-HDFS-10467-006.patch,
> HDFS-10630-HDFS-10467-007.patch, HDFS-10630-HDFS-10467-008.patch,
> HDFS-10630-HDFS-10467-009.patch
>
>
> Interface to store the federation shared state across Routers.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
