[
https://issues.apache.org/jira/browse/HDFS-10630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991914#comment-15991914
]
Chris Douglas commented on HDFS-10630:
--------------------------------------
Thanks for the update. Only a few, minor points:
* Extending {{PeriodicService}}, but using setRunnable in serviceInit seems
like there could be an abstract method that either returns, or is invoked by,
the periodic Runnable. The abstraction as a Service seems to mostly add a
lifecycle to the ScheduledExecutorService, with some metrics tracking
successful invocations. That seems like it could be a feature of the Service
rather than a composite, but if it's common enough to abstract then OK.
* If the {{StateStoreFileImpl}} and {{StateStoreFileSystemImpl}} can be used in
real environments, there isn't any necessary fencing or exclusion necessary to
prevent conflicts, partial updates, etc.? Is an external process responsible
for this?
Overall +1 to commit to the branch. It'll be easier to understand these in
context with the ZK changes.
> Federation State Store FS Implementation
> ----------------------------------------
>
> Key: HDFS-10630
> URL: https://issues.apache.org/jira/browse/HDFS-10630
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Inigo Goiri
> Assignee: Jason Kace
> Attachments: HDFS-10630.001.patch, HDFS-10630.002.patch,
> HDFS-10630-HDFS-10467-003.patch, HDFS-10630-HDFS-10467-004.patch,
> HDFS-10630-HDFS-10467-005.patch, HDFS-10630-HDFS-10467-006.patch,
> HDFS-10630-HDFS-10467-007.patch
>
>
> Interface to store the federation shared state across Routers.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
