[
https://issues.apache.org/jira/browse/HDFS-11359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030466#comment-16030466
]
Manoj Govindassamy edited comment on HDFS-11359 at 5/31/17 3:10 AM:
--------------------------------------------------------------------
[~linyiqun],
Thanks for the quick turnaround and providing the patch revision.
v005 patch looks good to me, +1.
DFSAdmin.java: (nit comment)
Good that you removed the old code duplication and created a new common method
{{printDataNodeReports()}}. You are passing the State's string also as an
argument, which really can be retrieved from {{AdminStates}}. Maybe the
AdminState's values are not are exactly same as the one you wanted?
was (Author: manojg):
[~linyiqun],
Thanks for the quick turnaround and providing the patch revision.
v005 patch: +1, with a nit comment below
DFSAdmin.java:
Good that you removed the old code duplication and created a new common method
{{printDataNodeReports()}}. You are passing the State's string also as an
argument, which really can be retrieved from {{AdminStates}}. Please check if
you can make use of it. Maybe the AdminState's values are not are exactly same
as the one you wanted?
> DFSAdmin report command supports displaying maintenance state datanodes
> -----------------------------------------------------------------------
>
> Key: HDFS-11359
> URL: https://issues.apache.org/jira/browse/HDFS-11359
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: 3.0.0-alpha1
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Priority: Minor
> Attachments: HDFS-11359.001.patch, HDFS-11359.002.patch,
> HDFS-11359.003.patch, HDFS-11359.004.patch, HDFS-11359.005.patch
>
>
> The datanode's maintenance state info can be showed in webUI/JMX. But it
> can't be displayed via CLI. This JIRA will improve on this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
