[
https://issues.apache.org/jira/browse/HDFS-11359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031345#comment-16031345
]
Yiqun Lin edited comment on HDFS-11359 at 5/31/17 3:26 PM:
-----------------------------------------------------------
[~manojg], thanks for your review!
bq. You are passing the State's string also as an argument, which really can be
retrieved from AdminStates. Maybe the AdminState's values are not are exactly
same as the one you wanted?
Yes, this can be improved by retrieving from AdminStates as your said. But
current AdminState's values may be not same as we wanted, for example,
{{Live/Dead datanodes}} cannot printed since there is only one state {{In
Service}} means this node is live and also there is no dead state AdminState
value. If we want to use AdminState's value to print node state infos, we maybe
need to make a minor change of current AdminState vaules as well. So I'd like
to keep current logic.
Will commit this the day after tomorrow in case others have some further
comments.
Thanks.
was (Author: linyiqun):
[~manojg], thanks for your review!
bq. You are passing the State's string also as an argument, which really can be
retrieved from AdminStates. Maybe the AdminState's values are not are exactly
same as the one you wanted?
Yes, this can be improbed by retrieving from AdminStates as your said. But
current AdminState's values may be not same as we wanted, for example,
{{Live/Dead datanodes}} cannot printed since there is only one state {{In
Service}} means this node is live and also there is no dead state AdminState
value. If we want to use AdminState's value to print node state infos, we maybe
need to make a minor change of current AdminState vaules as well. So I'd like
to keep current logic.
Will commit this the day after tomorrow in case others have some further
comments.
Thanks.
> DFSAdmin report command supports displaying maintenance state datanodes
> -----------------------------------------------------------------------
>
> Key: HDFS-11359
> URL: https://issues.apache.org/jira/browse/HDFS-11359
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: 3.0.0-alpha1
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Priority: Minor
> Attachments: HDFS-11359.001.patch, HDFS-11359.002.patch,
> HDFS-11359.003.patch, HDFS-11359.004.patch, HDFS-11359.005.patch
>
>
> The datanode's maintenance state info can be showed in webUI/JMX. But it
> can't be displayed via CLI. This JIRA will improve on this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
