[ 
https://issues.apache.org/jira/browse/HDFS-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103426#comment-16103426
 ] 

Anu Engineer commented on HDFS-12195:
-------------------------------------

[~yuanbo] Thank you for updating the patch. It looks quite good, I have 2 nits, 
I think we can commit this after those are addressed.
*KeyManager.java*
{code}
    List<KsmKeyInfo> listKeys(String keyPrefix, int maxKeys)
      throws IOException;
{code}
* Key Manager contains API's needed by the client. While I agree that this is 
needed by you, I don't think this should be part of KeyManager.
* please rename FAILED_KEY_NOT_FOUND ==> KEY_NOT_FOUND  

> Ozone: DeleteKey-1: KSM replies delete key request asynchronously
> -----------------------------------------------------------------
>
>                 Key: HDFS-12195
>                 URL: https://issues.apache.org/jira/browse/HDFS-12195
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Weiwei Yang
>            Assignee: Yuanbo Liu
>         Attachments: client-ksm.png, HDFS-12195-HDFS-7240.001.patch, 
> HDFS-12195-HDFS-7240.002.patch
>
>
> We will implement delete key in ozone in multiple child tasks, this is 1 of 
> the child task to implement client to scm communication. We need to do it in 
> async manner, once key state is changed in ksm metadata, ksm is ready to 
> reply client with a successful message. Actual deletes on other layers will 
> happen some time later.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to