[
https://issues.apache.org/jira/browse/HDFS-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105303#comment-16105303
]
Weiwei Yang commented on HDFS-12195:
------------------------------------
Hi [~yuanbo]
Some more comments
*OzoneConsts.java*
Can we change line 97 to:
{code}
public static final String DELETING_KEY_PREFIX = "#deleting#"
{code}
it seems not necessary to call "#" as a prefix.
*MetadataManager#getDeletedKeyName*
line 109 to 115: I don't think the java doc is correct. This method is used to
simply return a DB key for a key which is under deletion.
And like [~anu], [~vagarychen] both commented, please remove {{listKeys}} from
KSM API.
Thank you.
> Ozone: DeleteKey-1: KSM replies delete key request asynchronously
> -----------------------------------------------------------------
>
> Key: HDFS-12195
> URL: https://issues.apache.org/jira/browse/HDFS-12195
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Weiwei Yang
> Assignee: Yuanbo Liu
> Attachments: client-ksm.png, HDFS-12195-HDFS-7240.001.patch,
> HDFS-12195-HDFS-7240.002.patch
>
>
> We will implement delete key in ozone in multiple child tasks, this is 1 of
> the child task to implement client to scm communication. We need to do it in
> async manner, once key state is changed in ksm metadata, ksm is ready to
> reply client with a successful message. Actual deletes on other layers will
> happen some time later.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
