[
https://issues.apache.org/jira/browse/HDFS-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106924#comment-16106924
]
Weiwei Yang commented on HDFS-12195:
------------------------------------
Hi [~yuanbo]
Looks good. Some nits
1. Can we use all small letters prefix "#deleting#"?
2. the java doc for getDeletedKeyName() is still a bit confusing, please revise
it to
{code}
// Returns the DB key name of a deleted key in KSM metadata store.
// The name for a deleted key has prefix #deleting# followed by the actual key
name.
byte[] getDeletedKeyName(byte[] keyName);
{code}
3. Following method seems only be used in test case, please add
{{@VisibleForTesting}} tag
{code}
MetadataStore getStore();
{code}
others seems good.
Thanks.
> Ozone: DeleteKey-1: KSM replies delete key request asynchronously
> -----------------------------------------------------------------
>
> Key: HDFS-12195
> URL: https://issues.apache.org/jira/browse/HDFS-12195
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Weiwei Yang
> Assignee: Yuanbo Liu
> Attachments: client-ksm.png, HDFS-12195-HDFS-7240.001.patch,
> HDFS-12195-HDFS-7240.002.patch, HDFS-12195-HDFS-7240.003.patch
>
>
> We will implement delete key in ozone in multiple child tasks, this is 1 of
> the child task to implement client to scm communication. We need to do it in
> async manner, once key state is changed in ksm metadata, ksm is ready to
> reply client with a successful message. Actual deletes on other layers will
> happen some time later.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
