[ 
https://issues.apache.org/jira/browse/HDFS-12467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168646#comment-16168646
 ] 

Chen Liang commented on HDFS-12467:
-----------------------------------

I wonder why can't we just use {{inManualChillMode}} variable? do we really 
need to have the new {{chillMode}} flag? Also it seems to be changing the 
chillmode syntax. For example {{clearChillModeFlag()}} {{forceExitChillMode}} 
and {{forceEnterChillMode}} don't affect the new boolean {{chillMode}} flag. So 
If someone call {{getChillModeStatus}} after a {{forceEnterChillMode}}, it will 
be true for current code but may still be false with the patch. If the goal is 
to log all chill mode status change, then how about just adding log to the 
places where {{inManualChillMode}}'s value is changed?

> Ozone: SCM: NodeManager should log when it comes out of chill mode
> ------------------------------------------------------------------
>
>                 Key: HDFS-12467
>                 URL: https://issues.apache.org/jira/browse/HDFS-12467
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nandakumar
>            Assignee: Nandakumar
>            Priority: Minor
>         Attachments: HDFS-12467-HDFS-7240.000.patch
>
>
> {{NodeManager}} should add a log message when it comes out of chill mode.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to