[ 
https://issues.apache.org/jira/browse/HDFS-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207260#comment-16207260
 ] 

Weiwei Yang commented on HDFS-11468:
------------------------------------

Hi [~linyiqun]

It looks like the container state metrics added in {{SCMMetrics}} are actually 
metrics for last container report, correct? In that case, I think the metric 
names might need some re-word. Is it more meaningful to change

||Metric Name Before||After||
|size|lastConainerReportTotalSize|
|used|lastContainerReportTotalUsed|
|keyCount|lastContainerReportTotalKeyCount|
...

second, as we already have {{SCMMXBean}}, can we merge these metrics to that 
class?

Thanks

> Ozone: SCM: Add Node Metrics for SCM
> ------------------------------------
>
>                 Key: HDFS-11468
>                 URL: https://issues.apache.org/jira/browse/HDFS-11468
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Xiaoyu Yao
>            Assignee: Yiqun Lin
>            Priority: Critical
>              Labels: OzonePostMerge
>         Attachments: HDFS-11468-HDFS-7240.001.patch, 
> HDFS-11468-HDFS-7240.002.patch
>
>
> This ticket is opened to add node metrics in SCM based on heartbeat, node 
> report and container report from datanodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to