[ 
https://issues.apache.org/jira/browse/HDFS-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210765#comment-16210765
 ] 

Yiqun Lin commented on HDFS-11468:
----------------------------------

Thanks for the response, [~cheersyang].
I am thinking for this again . I will update the metric name for container stat 
metrics.

bq. These are SCM level metrics right? Is it a bit overlapping with SCMMXBean?
Yes, it looks node metrics in SCMMetrics has some overlapping with SCMMXBean. I 
looked into two similar classes NameNodeMXBean and NameNodeMetrics. The node 
count info is intended showed in Jmx interface rather than as metrics. So I'd 
like to remove node metrics and only keep container stat metrics in class 
SCMMetrics. But I insist on one point that we should kepp these two classes 
alone and not merge all metrics. That is mean the info exposed in *Metrics and 
*MXBean is a little different, like we have KSMMetrics and KSMMxBean, 
NameNodeMetrics and NameNodeMXBean.
Does it looks good to you now, [~cheersyang]?

> Ozone: SCM: Add Node Metrics for SCM
> ------------------------------------
>
>                 Key: HDFS-11468
>                 URL: https://issues.apache.org/jira/browse/HDFS-11468
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Xiaoyu Yao
>            Assignee: Yiqun Lin
>            Priority: Critical
>              Labels: OzonePostMerge
>         Attachments: HDFS-11468-HDFS-7240.001.patch, 
> HDFS-11468-HDFS-7240.002.patch, HDFS-11468-HDFS-7240.003.patch
>
>
> This ticket is opened to add node metrics in SCM based on heartbeat, node 
> report and container report from datanodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to