[
https://issues.apache.org/jira/browse/HDFS-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215127#comment-16215127
]
Weiwei Yang commented on HDFS-11468:
------------------------------------
Hi [~linyiqun]
Thanks for the new patch, it looks all good to me except a few nits on the
words in {{OzoneMetrics.md}}
bq. Storage Container Manager (SCM) is the block and cluster manager for HDFS
Ozone. SCM along with data nodes offer a service called 'containers'.
Can we revise this sentence to: Storage Container Manager (SCM) is a master
service which keeps track of replicas of storage containers. It also manages
all data nodes and their states, dealing with container reports and dispatching
commands for execution. (I think it is better to mention it handles container
reports so it is easier for user to understand their metrics)
bq. Total number of container size
>> Total size in bytes of all containers
bq. Total number of bytes used by the container
>> Total number of bytes used by all containers
bq. Total number of keys in the container
>> Total number of keys in all containers
bq. Total number of bytes read from the container
>> Total number of bytes have been read from all containers
bq. Total number of bytes write into the container
>> Total number of bytes have been written into all containers
bq. Total number of times the container is read
>> Total number of times containers have been read from
bq. Total number of times the container is written into
>> Total number of times containers have been written to
Mostly I revised "container" to "containers" because these counters are the
accumulated values from all containers in last container report.
Does it make sense? Thanks
> Ozone: SCM: Add Node Metrics for SCM
> ------------------------------------
>
> Key: HDFS-11468
> URL: https://issues.apache.org/jira/browse/HDFS-11468
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Xiaoyu Yao
> Assignee: Yiqun Lin
> Priority: Critical
> Labels: OzonePostMerge
> Attachments: HDFS-11468-HDFS-7240.001.patch,
> HDFS-11468-HDFS-7240.002.patch, HDFS-11468-HDFS-7240.003.patch,
> HDFS-11468-HDFS-7240.004.patch, HDFS-11468-HDFS-7240.005.patch
>
>
> This ticket is opened to add node metrics in SCM based on heartbeat, node
> report and container report from datanodes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
