[ 
https://issues.apache.org/jira/browse/HDFS-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047374#comment-13047374
 ] 

Suresh Srinivas commented on HDFS-2058:
---------------------------------------

> As I was doing this I noted that it's kind of silly that we even send 
> DatanodeInfo as part of the pipeline. All of the fields are unused for data 
> transfer, right? All we really need is DatanodeId here, no?

You are right. But do you think the information we are sending could be useful 
for the client. I prefer leaving it as it is now.

+1 for the change. 

Since findbugs warnings are for generated code - we should just suppress them 
in src/test/findbugsExclude.xml. I have not looked at javac warnings.

> DataTransfer Protocol using protobufs
> -------------------------------------
>
>                 Key: HDFS-2058
>                 URL: https://issues.apache.org/jira/browse/HDFS-2058
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2058.patch, hdfs-2058.txt, hdfs-2058.txt, 
> hdfs-2058.txt
>
>
> We've been talking about this for a long time... would be nice to use 
> something like protobufs or Thrift for some of our wire protocols.
> I knocked together a prototype of DataTransferProtocol on top of proto bufs 
> that seems to work.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to