[
https://issues.apache.org/jira/browse/HDFS-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047516#comment-13047516
]
Suresh Srinivas commented on HDFS-2058:
---------------------------------------
Comments for the patch in this jira:
# Name ProtoUtil.java HDFSProtoUtil.java
# With change in build.xml, do you still need to add generated file?
Comments: (could be taken care of in a separate jira)
# Move ByteBufferOutputStream to common
# Create ProtoUtil.java in common and move vint related methods into that.
# ExactSizeInputStream constructor needs javadoc. Calling the parameter
numBytes as remaining seems more appropriate.
# For the tests added instead of catching the exception with expected comments,
you could do @Test(expected = EOFException.class)
> DataTransfer Protocol using protobufs
> -------------------------------------
>
> Key: HDFS-2058
> URL: https://issues.apache.org/jira/browse/HDFS-2058
> Project: Hadoop HDFS
> Issue Type: New Feature
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.23.0
>
> Attachments: HDFS-2058.patch, hdfs-2058.txt, hdfs-2058.txt,
> hdfs-2058.txt, hdfs-2058.txt
>
>
> We've been talking about this for a long time... would be nice to use
> something like protobufs or Thrift for some of our wire protocols.
> I knocked together a prototype of DataTransferProtocol on top of proto bufs
> that seems to work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
