[ 
https://issues.apache.org/jira/browse/HDFS-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047767#comment-13047767
 ] 

Suresh Srinivas commented on HDFS-2058:
---------------------------------------

+1 for the change.

> it problematic since I want to only be sure that the exception is thrown at 
> that one spot in the test, and not earlier or later than it's supposed to be.

Your tests are small enough and the your check is specific enough. So there is 
not other code that could throw EOFException.

> DataTransfer Protocol using protobufs
> -------------------------------------
>
>                 Key: HDFS-2058
>                 URL: https://issues.apache.org/jira/browse/HDFS-2058
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2058.patch, hdfs-2058.txt, hdfs-2058.txt, 
> hdfs-2058.txt, hdfs-2058.txt, hdfs-2058.txt
>
>
> We've been talking about this for a long time... would be nice to use 
> something like protobufs or Thrift for some of our wire protocols.
> I knocked together a prototype of DataTransferProtocol on top of proto bufs 
> that seems to work.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to