[ 
https://issues.apache.org/jira/browse/HDFS-12904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293524#comment-16293524
 ] 

Íñigo Goiri commented on HDFS-12904:
------------------------------------

Actually, [~lukmajercak] and [~thinktaocs] went through the code and there is 
another {{sendBlock()}}:
{{BPOfferService#processCommandFromActive()}} -> {{DataNode#transferBlocks()}} 
-> {{DataNode#transferBlock()}} -> {{DataTransfer#run()}} finally calls 
{{BlockSender#sendBlock()}} without a throttler.
This will start a {{DataXceiver}} in the other side which will be throttled but 
we should also throttle the one that sends.
I don't see a proper way to distinguish those.
In any case, we may want to throttle the one in {{DataTransfer#run()}}.
Thoughts?


> Add DataTransferThrottler to the Datanode transfers
> ---------------------------------------------------
>
>                 Key: HDFS-12904
>                 URL: https://issues.apache.org/jira/browse/HDFS-12904
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: datanode
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>            Priority: Minor
>         Attachments: HDFS-12904.000.patch, HDFS-12904.001.patch
>
>
> The {{DataXceiverServer}} already uses throttling for the balancing. The 
> Datanode should also allow throttling the regular data transfers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to