[ 
https://issues.apache.org/jira/browse/HDFS-12772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334979#comment-16334979
 ] 

Íñigo Goiri commented on HDFS-12772:
------------------------------------

[~hanishakoneru], [~linyiqun], at the end I went ahead and split this in 4:
* HDFS-12772 for storing the Router state in the State Store
* HDFS-13042 for the Router to heartbeat its state to the State Store
* HDFS-13043 to expose this in the federation UI
* HDFS-13044 to add a new safe mode

[~linyiqun] thanks for the review, I fixed most in  [^HDFS-12772.003.patch], 
leaving a couple open points:
* {{getRouterRegistration()}} is to get the registration for a particular 
Router while {{getRouterRegistrations()}} gets all of them. As we use the 
Request/Reponse interface this is not as clear but I think it should be clear 
enough with: {{RouterState getRouterRegistration(String routerId)}} and 
{{List<RouterState> getRouterRegistrations()}}
* For the timestamp, the single one doesn't have the timestamp of the query as 
it's a particular entity that we query. I could remove the timestamp from the 
{{getRouterRegistrations()}}.

> RBF: Federation Router State State Store internal API
> -----------------------------------------------------
>
>                 Key: HDFS-12772
>                 URL: https://issues.apache.org/jira/browse/HDFS-12772
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>            Priority: Major
>         Attachments: HDFS-12772.000.patch, HDFS-12772.001.patch, 
> HDFS-12772.002.patch, HDFS-12772.003.patch
>
>
> To monitor the state of the cluster, we should track the state of the 
> routers. This should be exposed in the UI.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to