[
https://issues.apache.org/jira/browse/HDFS-12772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335580#comment-16335580
]
Yiqun Lin commented on HDFS-12772:
----------------------------------
The latest patch almost looks good to me, [~elgoiri].
{quote}For the timestamp, the single one doesn't have the timestamp of the
query as it's a particular entity that we query. I could remove the timestamp
from the {{getRouterRegistrations()}}.
{quote}
I‘m okay for keeping timestamp in {{getRouterRegistrations()}}. Since it will
let us know when the router states were queried from state store records cache.
One minor comment:
The relevant methods to the field {{rebalancerVersion}}, {{pathLockVersion,
}}{{tokenVersion}} didn't defined in {{StateStoreVersion.java}}. The parameters
of these fields also didn't used in {{newInstance}} method
{code:java}
+ public static StateStoreVersion newInstance(long membershipVersion,
+ long mountTableVersion, long rebalancerVersion, long pathLockVersion,
+ long tokenVersion) {
+ StateStoreVersion record = newInstance();
+ record.setMembershipVersion(membershipVersion);
+ record.setMountTableVersion(mountTableVersion);
+ return record;
+ }
{code}
> RBF: Federation Router State State Store internal API
> -----------------------------------------------------
>
> Key: HDFS-12772
> URL: https://issues.apache.org/jira/browse/HDFS-12772
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 3.0.0
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: HDFS-12772.000.patch, HDFS-12772.001.patch,
> HDFS-12772.002.patch, HDFS-12772.003.patch, HDFS-12772.004.patch
>
>
> To monitor the state of the cluster, we should track the state of the
> routers. This should be exposed in the UI.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
