[ 
https://issues.apache.org/jira/browse/HDFS-13059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338432#comment-16338432
 ] 

Íñigo Goiri commented on HDFS-13059:
------------------------------------

Thanks [~ajayydv], a couple comments on  [^HDFS-13059.002.patch]:
* * I would add a comment explaining what dataset looks like. This would 
basically be a reference on what the output for {{getDFSUsedData()}} looks like.
* There are a couple extra lines in {{dfshealth.html}} which I'm not sure are 
needed.
* It would be good to do the histogram part of {{dfs-visualizations.js}} but it 
doesn't have to be part of this JIRA.
* The indentation on {{hadoop.css}} is not very consistent.
* I would probably make the tooltip a little wider.

Other than this small comments, this is good and I think is useful.

> Add pie chart in NN UI to show storage used
> -------------------------------------------
>
>                 Key: HDFS-13059
>                 URL: https://issues.apache.org/jira/browse/HDFS-13059
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>         Attachments: HDFS-13059.001.patch, HDFS-13059.002.patch, Screen Shot 
> 2018-01-24 at 1.58.28 PM.png, Screen Shot 2018-01-24 at 1.58.33 PM.png, 
> Screen Shot 2018-01-24 at 3.04.17 PM.png
>
>
> This jira proposes to add a pie chart in NN UI to show storage used by:
> * DFS Used (Tooltip : "Storage currently used for DFS.")
> * DFS available (Tooltip : "Storage available for DFS use.")
> * Non DFS Used (Tooltip : "Storage allocated for DFS but currently" +
>      " used by Non DFS storage.")
> Tooltip will help users better understand what these terms mean.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to