[
https://issues.apache.org/jira/browse/HDFS-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408194#comment-16408194
]
Íñigo Goiri commented on HDFS-13291:
------------------------------------
Thanks [~linyiqun] for [^HDFS-13291.003.patch].
* I would add a test case to TestRouterAllResolver.
* In AvailableSpaceResolver there is split of lines earlier than 80 in lines
54, 65, and 129 (it's minor but looks unnecesary).
* We could add the corner cases for {{verifyRank()}}: 1, 0.5, 0.0, and
BALANCER_PREFERENCE_DEFAULT. Not sure is worth chekcing the illegal cases
(e.g., -1, 2).
As a general comment, LocalResolver and RandomResolver are very similar.
It might be good to refactor a little and extract the shared implementation.
> RBF: Implement available space based OrderResolver
> --------------------------------------------------
>
> Key: HDFS-13291
> URL: https://issues.apache.org/jira/browse/HDFS-13291
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 3.0.0
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Priority: Major
> Attachments: HDFS-13291.001.patch, HDFS-13291.002.patch,
> HDFS-13291.003.patch
>
>
> Implement available space based OrderResolver, this type resolver will
> benefit for balancing the data across subclusters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
