[
https://issues.apache.org/jira/browse/HDFS-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411849#comment-16411849
]
Plamen Jeliazkov commented on HDFS-13331:
-----------------------------------------
Attaching initial patch (based on top of HDFS-12943 branch).
Couple major changes to observe from HDFS-12977:
1) I removed the long field lastSeenStateId from DFSClient and replaced it with
a field for the AlignmentContext. This fixed the last checkstyle and simplified
from having to store the lastSeenStateId twice (in ClientGCIContext and
DFSClient).
2) ClientGCIContext no longer needs dependency on DFSClient as a result. No
constructor necessary.
3) I added a new method in AlignmentContext that takes
RpcRequestHeaderProto.Builder and updates the stateId proto field. Does nothing
on server side.
4) Visible for testing methods added: Client.getAlignmentContext in order to
facilitate a new test with Mockito spying. ClientGCIContext.getLastSeenStateId
and DFSClient.getLastSeenSateId in facilitate (1) and keep tests simple.
> Add lastSeenStateId to RpcRequestHeader.
> ----------------------------------------
>
> Key: HDFS-13331
> URL: https://issues.apache.org/jira/browse/HDFS-13331
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Plamen Jeliazkov
> Assignee: Plamen Jeliazkov
> Priority: Major
> Attachments: HDFS_13331.trunk.000.patch
>
>
> HDFS-12977 added a stateId into the RpcResponseHeader which is returned by
> NameNode and stored by DFSClient.
> This JIRA is to followup on that work and have the DFSClient send their
> stored "lastSeenStateId" in the RpcRequestHeader so that ObserverNodes can
> then compare with their own and act accordingly.
> This JIRA work focuses on just the part of making DFSClient send their state
> through RpcRequestHeader.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]