[ 
https://issues.apache.org/jira/browse/HDFS-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412318#comment-16412318
 ] 

Konstantin Shvachko commented on HDFS-13331:
--------------------------------------------

Thanks, Plamen. The changes looks good.
# I would make {{getLastSeenStateId()}} public in GCI contexts. I mean who are 
we hiding it from. Then you don't need @VisibleForTesting I guess.
# You should also add some server-side logic in the call receiving the context. 
I think we can just compare it the received {{stateId}} with the {{stateId}} of 
the node and log a warning if the received Id is higher. It does nothing for 
now, but sets the tone for next steps.

> Add lastSeenStateId to RpcRequestHeader.
> ----------------------------------------
>
>                 Key: HDFS-13331
>                 URL: https://issues.apache.org/jira/browse/HDFS-13331
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Plamen Jeliazkov
>            Assignee: Plamen Jeliazkov
>            Priority: Major
>         Attachments: HDFS_13331.trunk.000.patch
>
>
> HDFS-12977 added a stateId into the RpcResponseHeader which is returned by 
> NameNode and stored by DFSClient.
> This JIRA is to followup on that work and have the DFSClient send their 
> stored "lastSeenStateId" in the RpcRequestHeader so that ObserverNodes can 
> then compare with their own and act accordingly.
> This JIRA work focuses on just the part of making DFSClient send their state 
> through RpcRequestHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to