[
https://issues.apache.org/jira/browse/HDFS-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450353#comment-16450353
]
Erik Krogen commented on HDFS-13286:
------------------------------------
Thanks Chao!
{quote}Fixed. Some of them I just followed the previous code (e.g.,
transitionToStandby): should I fix the other code too?{quote}
My usual approach is to avoid introducing new checkstyle issues but only fix
old ones if the line is being modified anyway. I am not sure if this is
necessarily the official policy, but it does make precommit the happiest.
{quote}Yes noticed. These are trailing whitespace from previous commits, and
for some reason my IDE will automatically eliminate them. Let me add them
back...{quote}
If you use IntelliJ, there is an option for only trimming whitespace from
modified lines that I find useful.
{quote}With the latter it needs to be changed to if (state != STANDBY_STATE &&
state != OBSERVER_STATE), which is more verbose though. I'm thinking just to
update the comment. What do you think?{quote}
Sounds fine to me.
> Add haadmin commands to transition between standby and observer
> ---------------------------------------------------------------
>
> Key: HDFS-13286
> URL: https://issues.apache.org/jira/browse/HDFS-13286
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-13286-HDFS-12943.000.patch,
> HDFS-13286-HDFS-12943.001.patch
>
>
> As discussed in HDFS-12975, we should allow explicit transition between
> standby and observer through haadmin command, such as:
> {code}
> haadmin -transitionToObserver
> {code}
> Initially we should support transition from observer to standby, and standby
> to observer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
