[ 
https://issues.apache.org/jira/browse/HDFS-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452731#comment-16452731
 ] 

Chao Sun commented on HDFS-13286:
---------------------------------

Thanks [~xkrogen]. Will address the issues. In the style issues though:
{code}
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/DummyHAService.java:59:
  boolean failToBecomeActive, failToBecomeStandby, failToBecomeObserver,:11: 
Variable 'failToBecomeActive' must be private and have accessor methods. 
[VisibilityModifier]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/DummyHAService.java:59:
  boolean failToBecomeActive, failToBecomeStandby, failToBecomeObserver,:31: 
Variable 'failToBecomeStandby' must be private and have accessor methods. 
[VisibilityModifier]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/DummyHAService.java:59:
  boolean failToBecomeActive, failToBecomeStandby, failToBecomeObserver,:52: 
Variable 'failToBecomeObserver' must be private and have accessor methods. 
[VisibilityModifier]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/DummyHAService.java:60:
      failToFence;:7: Variable 'failToFence' must be private and have accessor 
methods. [VisibilityModifier]
{code}

This might be more involved and is not so related to this JIRA. Should we leave 
them as it is for now?

> Add haadmin commands to transition between standby and observer
> ---------------------------------------------------------------
>
>                 Key: HDFS-13286
>                 URL: https://issues.apache.org/jira/browse/HDFS-13286
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Chao Sun
>            Assignee: Chao Sun
>            Priority: Major
>         Attachments: HDFS-13286-HDFS-12943.000.patch, 
> HDFS-13286-HDFS-12943.001.patch, HDFS-13286-HDFS-12943.002.patch
>
>
> As discussed in HDFS-12975, we should allow explicit transition between 
> standby and observer through haadmin command, such as:
> {code}
> haadmin -transitionToObserver
> {code}
> Initially we should support transition from observer to standby, and standby 
> to observer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to