[ 
https://issues.apache.org/jira/browse/HDFS-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461756#comment-16461756
 ] 

Erik Krogen commented on HDFS-13286:
------------------------------------

For {{FailoverController#preFailoverChecks()}}, I agree with your logic, but we 
need to update the error message here:
{code}
    if (!toSvcStatus.getState().equals(HAServiceState.STANDBY)) {
      throw new FailoverFailedException(
          "Can't failover to an active service");
    }
{code}
Currently if you tried to failover to OBSERVER, you would get the message that 
you can't failover to an active service. We should update to "Can't failover to 
a service not in standby state" or something like that.

Agreed with leaving {{FederationNamenodeServiceState}} for a follow-on JIRA 
targeted at RBF support. Created HDFS-13522.

> Add haadmin commands to transition between standby and observer
> ---------------------------------------------------------------
>
>                 Key: HDFS-13286
>                 URL: https://issues.apache.org/jira/browse/HDFS-13286
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Chao Sun
>            Assignee: Chao Sun
>            Priority: Major
>         Attachments: HDFS-13286-HDFS-12943.000.patch, 
> HDFS-13286-HDFS-12943.001.patch, HDFS-13286-HDFS-12943.002.patch, 
> HDFS-13286-HDFS-12943.003.patch, HDFS-13286-HDFS-12943.004.patch
>
>
> As discussed in HDFS-12975, we should allow explicit transition between 
> standby and observer through haadmin command, such as:
> {code}
> haadmin -transitionToObserver
> {code}
> Initially we should support transition from observer to standby, and standby 
> to observer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to